Skip to content

Conversation

@margalva
Copy link
Collaborator

Remove limit on parameters input field. Work-around while a better implementation is designed.

Remove limit on parameters input field. Work-around while a better implementation is designed.
@margalva margalva merged commit efdf270 into main Jun 28, 2024
@margalva margalva deleted the fix/remove_params_limit branch June 28, 2024 13:40
Copy link
Contributor

@randallfrank randallfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@margalva @viseshrp You are not concerned about backward compatibility here? I was just thinking that the maximum length is server API specific, assuming the server protocol number changed with the maximum length change.

@margalva
Copy link
Collaborator Author

margalva commented Jul 1, 2024

@randallfrank As we're opening up the limit so now it's larger than it used to, it shouldn't pose backward compatibility issues, as far as I see it. Old cases will work with the new API. New cases won't work against old APIs, but that's not the suggested direction anyway - we don't even let you start a server from an old version on top of a new database.

@viseshrp
Copy link
Collaborator

viseshrp commented Jul 1, 2024

@randallfrank I fail to see the backwards incompatibility here as it is just an extension of the number of allowed chars, as @margalva has mentioned. I also don't see the need to bump the server version due to the restrictions stated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants