-
Notifications
You must be signed in to change notification settings - Fork 8
Update packaging guide #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packaging guide #44
Conversation
|
@akaszynski I noticed e.g. in "Development Practices" there are some places referring to pip install -r requirements_test.txtSince the template now uses optional requirements for this it might be better to change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the changes and appreciate the discussion of the merits of filt vs poetry.
|
@greschd, let's modify this to reflect our choice in |
|
LGTM. |
|
Pinging @jorgepiloto to update this based on ansys/ansys-templates#2 |
82215aa to
2969efd
Compare
16af98a to
fff0808
Compare
9fbb90e to
38a1ae9
Compare
|
Thanks for your work @greschd! |
Remove guide regarding
setup.py, and recommendflitwithpyproject.tomlinstead. For applications (which should have pinned versions instead of loose ones), recommendpoetry.