- 
                Notifications
    
You must be signed in to change notification settings  - Fork 201
 
REFACTOR: Solution Data #6706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            REFACTOR: Solution Data #6706
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          Codecov Report❌ Patch coverage is  ❌ Your patch status has failed because the patch coverage (69.02%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@             Coverage Diff             @@
##             main    #6706       +/-   ##
===========================================
+ Coverage   28.07%   83.16%   +55.09%     
===========================================
  Files         245      245               
  Lines       77393    77426       +33     
===========================================
+ Hits        21729    64395    +42666     
+ Misses      55664    13031    -42633     🚀 New features to boost your workflow:
  | 
    
              
                    Samuelopez-ansys
  
              
              approved these changes
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Refactored SolutionData class to use ONLY numpy arrays to browse solution data.
Some changes are breaking changes because we move from a comple and dirty dict[dict[list]] structure to a dict[numpy] structure. The dict is still present because it is used to index the expressions in SolutionData
this class is now much faster especially on huge solutions where there are hundreds of thousands of points
the enable_pandas_output is now useless and will be removed (or replaced by polars in the future)
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist