Skip to content

Conversation

@maxcapodi78
Copy link
Collaborator

Description

Refactored SolutionData class to use ONLY numpy arrays to browse solution data.
Some changes are breaking changes because we move from a comple and dirty dict[dict[list]] structure to a dict[numpy] structure. The dict is still present because it is used to index the expressions in SolutionData
this class is now much faster especially on huge solutions where there are hundreds of thousands of points
the enable_pandas_output is now useless and will be removed (or replaced by polars in the future)

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@maxcapodi78 maxcapodi78 requested a review from a team as a code owner September 29, 2025 19:32
@github-actions github-actions bot added the bug Something isn't working label Sep 29, 2025
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 69.02174% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.16%. Comparing base (038b1c0) to head (e7fb97c).
⚠️ Report is 6 commits behind head on main.

❌ Your patch status has failed because the patch coverage (69.02%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6706       +/-   ##
===========================================
+ Coverage   28.07%   83.16%   +55.09%     
===========================================
  Files         245      245               
  Lines       77393    77426       +33     
===========================================
+ Hits        21729    64395    +42666     
+ Misses      55664    13031    -42633     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys merged commit 8606592 into main Oct 6, 2025
38 of 39 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_solution_data branch October 6, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants