Skip to content

Conversation

@hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented Jul 23, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@hui-zhou-a hui-zhou-a requested a review from a team as a code owner July 23, 2025 10:25
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@ansys-cla-bot
Copy link

ansys-cla-bot bot commented Jul 23, 2025

The following people have not signed the Contributors License Agreement (CLA):

Read the CLA in the link above and sign it by clicking the link below:

You will receive a confirmation as soon as your signature is captured.

@github-actions github-actions bot added the bug Something isn't working label Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (2f6b548) to head (6f147ba).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6458       +/-   ##
===========================================
+ Coverage   50.24%   82.43%   +32.18%     
===========================================
  Files         230      230               
  Lines       73681    73681               
===========================================
+ Hits        37023    60740    +23717     
+ Misses      36658    12941    -23717     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) July 23, 2025 12:06
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgepiloto
Copy link
Member

Commit 6e5e40e was likely made by user https://github.com/samomania21, which no longer exists.

@SMoraisAnsys
Copy link
Collaborator

Commit 6e5e40e was likely made by user https://github.com/samomania21, which no longer exists.

This commit was performed by @hui-zhou-a. ring630 was his previous github name which he changed a few months ago.

@Samuelopez-ansys Samuelopez-ansys merged commit eb196b3 into main Jul 23, 2025
92 of 112 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix-edb-import branch July 23, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants