Skip to content

Conversation

@Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Jul 15, 2025

Description

Migrate to new common class and implement unit test.

Issue linked

Close #6362

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner July 15, 2025 12:26
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Jul 15, 2025
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 94.25287% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.42%. Comparing base (2da9354) to head (02c8e0b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6417      +/-   ##
==========================================
- Coverage   82.44%   82.42%   -0.03%     
==========================================
  Files         230      230              
  Lines       73686    73725      +39     
==========================================
+ Hits        60751    60768      +17     
- Misses      12935    12957      +22     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Copy link
Member Author

Hi @SMoraisAnsys @ecoussoux-ansys not sure if the unit tests are correctly implemented, please could you double check?

eblanco-ansys
eblanco-ansys previously approved these changes Jul 22, 2025
@Samuelopez-ansys Samuelopez-ansys merged commit ce0cb3b into main Jul 25, 2025
116 of 123 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_6362 branch July 25, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate circuit configuration extension

5 participants