FIX: Support for Maxwell Transient APhi Solver renaming in 2025R2 #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Samuelopez-ansys merged 20 commits into main from fix/maxwell-transient-aphi-renaming

Jul 17, 2025

Contributor

jvela018 commented Jul 15, 2025


          fix: Support for Transient APhi renaming in 2025R2

2763a4a

jvela018 self-assigned this

jvela018 requested a review from a team as a code owner

July 15, 2025 08:11

Contributor

ansys-reviewer-bot bot commented Jul 15, 2025

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

jvela018 linked an issue

that may be closed by this pull request

Some methods fail for Transient APhi solver #6413

Closed

github-actions bot added the bug label


          chore: adding changelog file 6414.fixed.md [dependabot-skip]

27a690d

codecov bot commented Jul 15, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (280d18f) to head (e94cac9).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6414      +/-   ##
==========================================
+ Coverage   84.36%   85.43%   +1.07%     
==========================================
  Files         175      175              
  Lines       66477    66479       +2     
==========================================
+ Hits        56080    56795     +715     
+ Misses      10397     9684     -713

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gmalinve reviewed

View reviewed changes

src/ansys/aedt/core/modeler/cad/primitives_3d.py Outdated Show resolved Hide resolved

gmalinve reviewed

View reviewed changes

src/ansys/aedt/core/maxwell.py Outdated Show resolved Hide resolved

gmalinve reviewed

View reviewed changes

src/ansys/aedt/core/maxwell.py Outdated Show resolved Hide resolved

gmalinve reviewed

View reviewed changes

src/ansys/aedt/core/maxwell.py Show resolved Hide resolved

gmalinve reviewed

View reviewed changes

src/ansys/aedt/core/maxwell.py Outdated Show resolved Hide resolved

jvela018 and others added 8 commits

July 15, 2025 13:25


          Update src/ansys/aedt/core/modeler/cad/primitives_3d.py

999a863

Co-authored-by: Giulia Malinverno <[email protected]>


          Update src/ansys/aedt/core/maxwell.py

Co-authored-by: Giulia Malinverno <[email protected]>


          Update src/ansys/aedt/core/maxwell.py

94bfbf5

Co-authored-by: Giulia Malinverno <[email protected]>


          Update src/ansys/aedt/core/maxwell.py

370a9a8

Co-authored-by: Giulia Malinverno <[email protected]>


          Update src/ansys/aedt/core/maxwell.py

9dfd951

Co-authored-by: Giulia Malinverno <[email protected]>


          fix: ensure pre-commit is correct

bcec2ad


          Merge branch 'main' into fix/maxwell-transient-aphi-renaming


          Merge branch 'main' into fix/maxwell-transient-aphi-renaming

1cc60dc

Member

Samuelopez-ansys commented Jul 16, 2025

@jvela018 I am running this branch in 2025R2 to verify that it works. Thank you for your fast refactoring!

Samuelopez-ansys and others added 2 commits

July 17, 2025 08:33


          Withdraw to True

58714fc


          Merge branch 'main' into fix/maxwell-transient-aphi-renaming

8644c9e

SMoraisAnsys previously approved these changes

View reviewed changes

Collaborator

SMoraisAnsys left a comment

LGTM, I left a few minor comments.
Thanks for modifying the tests, rendering the main windows isn't required.

src/ansys/aedt/core/maxwell.py Outdated Show resolved Hide resolved

src/ansys/aedt/core/maxwell.py Outdated Show resolved Hide resolved

src/ansys/aedt/core/maxwell.py Outdated Show resolved Hide resolved

src/ansys/aedt/core/modeler/cad/primitives_3d.py Outdated Show resolved Hide resolved

Samuelopez-ansys and others added 3 commits

July 17, 2025 12:31


          Fix configure layout

78625a7


          Merge remote-tracking branch 'origin/fix/maxwell-transient-aphi-renam…

fc54717

…ing' into fix/maxwell-transient-aphi-renaming


          Update src/ansys/aedt/core/maxwell.py

e117a11

Co-authored-by: Sébastien Morais <[email protected]>

Samuelopez-ansys dismissed SMoraisAnsys’s stale review via

e117a11

July 17, 2025 10:33


          Merge remote-tracking branch 'origin/fix/maxwell-transient-aphi-renam…

98d2080

…ing' into fix/maxwell-transient-aphi-renaming

Samuelopez-ansys and others added 4 commits

July 17, 2025 12:34


          Fix configure layout

f5b25b8


          Update src/ansys/aedt/core/maxwell.py

2e3738c

Co-authored-by: Sébastien Morais <[email protected]>


          Update src/ansys/aedt/core/modeler/cad/primitives_3d.py

7ac4315

Co-authored-by: Sébastien Morais <[email protected]>


          Merge remote-tracking branch 'origin/fix/maxwell-transient-aphi-renam…

e94cac9

…ing' into fix/maxwell-transient-aphi-renaming

Member

Samuelopez-ansys commented Jul 17, 2025

@SMoraisAnsys @jvela018 I had to add a few things that were also breaking the UT in 2025R2. Please review it again.

Samuelopez-ansys approved these changes

View reviewed changes

Member

Samuelopez-ansys left a comment

LGTM. PyAEDT is compatible again with 2025R2

Samuelopez-ansys merged commit 01bad04 into main

37 checks passed

Samuelopez-ansys deleted the fix/maxwell-transient-aphi-renaming branch

July 17, 2025 13:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug