-
Notifications
You must be signed in to change notification settings - Fork 1
feat: tech review #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I've seen there are some issues on the tests, coming from the |
MaxJPRey
reviewed
Aug 25, 2023
Co-authored-by: Maxime Rey <[email protected]>
MaxJPRey
reviewed
Aug 25, 2023
MaxJPRey
reviewed
Aug 25, 2023
Co-authored-by: Maxime Rey <[email protected]>
Co-authored-by: Maxime Rey <[email protected]>
RobPasMue
commented
Aug 26, 2023
RobPasMue
commented
Aug 26, 2023
Contributor
|
Thanks @RobPasMue for this thorough review m. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New features or code improvements
maintenance
Package and maintenance related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing minimum requirements and general enhancements. Listing changes:
scriptsfolder 7f4b061dockerfolder 58c827b3.Xfe0e0dcpyproject.toml3914c7dMAJOR.MINOR.PATCH.devXtoMAJOR.MINOR.PATCH/devX- no need for extra element since dev versions should be the minor branches 04048dfdoc/_build/html9d5f1eeEnumfor classes only holding constants b819e7f 8dc6180 f2c91ffThere are more changes to come though since the
ansys-api-additivepackage has to be made public (and reviewed). At that point, we will have to remove all references to the private PyPI. This is my next step.However, there are also a couple of major changes and suggestions that I have noted... proposing them here before actually performing the changes since they will impact most of the codebase
ansys-additivetoansys-additive-core(package rename, folder structure, import statements... a lot of affected files)Please @pkrull-ansys - comment on the above suggestions and changes made before proceding to perform more changes.