Skip to content

Conversation

@greschd
Copy link
Member

@greschd greschd commented May 15, 2023

Relax the requirement on protobuf, to allow using its
4.x releases. See ansys/ansys-api-template#10.

Needs ansys-tools-protoc-helper release 0.4 or newer,
to compile with protoc version 3.19, see https://github.com/ansys-internal/ansys-tools-protoc-helper#upgrade-plans

@plule-ansys
Copy link

Just to confirm: I've been able to make a test yesterday with protobuf 4 + pymapdl + pypim, and it works with ansys-api-platform-instancemanagement v1.0.0b4 released yesterday

@greschd
Copy link
Member Author

greschd commented Aug 4, 2023

Yeah, just looking for a committer on this one - @germa89?

@germa89
Copy link
Collaborator

germa89 commented Aug 7, 2023

I will check this and approve and merge along the week. Thank you @greschd @plule-ansys

@greschd
Copy link
Member Author

greschd commented Oct 4, 2023

merge along the week

😉

@RobPasMue
Copy link
Member

Let's get this merged yeah! =)

@germa89 germa89 merged commit 0e40238 into ansys:main Oct 10, 2023
@germa89
Copy link
Collaborator

germa89 commented Oct 10, 2023

Merged (Finally!)

I was a bit (a lot) hesitating because the lack of test we have in this package.

@germa89
Copy link
Collaborator

germa89 commented Oct 10, 2023

I'm considering to do a patch release. But the issue is we match this version with MAPDL server version..... so I dont think I should bump this one, without the other one.

@greschd do you need a patch release?

@RobPasMue
Copy link
Member

We would need a release to ensure that the metapackage is flexible with the protobuf version.

germa89 pushed a commit that referenced this pull request Mar 14, 2024
* Update ci.yml

* Allow using protobuf 4.x releases (#11)

* Bump version to 0.5.2

---------

Co-authored-by: Alex Kaszynski <[email protected]>
@koubaa
Copy link

koubaa commented Jul 8, 2024

@germa89 @greschd @Gryfenfer97

I don't see 0.5.2 on pypi. Was it released elsewhere and is there a reason we can't release it on pypi?

@greschd
Copy link
Member Author

greschd commented Jul 8, 2024

I think it was just never tagged + pushed, see #13 (comment)

@germa89
Copy link
Collaborator

germa89 commented Jul 9, 2024

New release is out: https://github.com/ansys/ansys-api-mapdl/releases/tag/v0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants