-
Notifications
You must be signed in to change notification settings - Fork 2
Allow using protobuf 4.x releases #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just to confirm: I've been able to make a test yesterday with protobuf 4 + pymapdl + pypim, and it works with |
|
Yeah, just looking for a committer on this one - @germa89? |
|
I will check this and approve and merge along the week. Thank you @greschd @plule-ansys |
😉 |
|
Let's get this merged yeah! =) |
|
Merged (Finally!) I was a bit (a lot) hesitating because the lack of test we have in this package. |
|
I'm considering to do a patch release. But the issue is we match this version with MAPDL server version..... so I dont think I should bump this one, without the other one. @greschd do you need a patch release? |
|
We would need a release to ensure that the metapackage is flexible with the protobuf version. |
* Update ci.yml * Allow using protobuf 4.x releases (#11) * Bump version to 0.5.2 --------- Co-authored-by: Alex Kaszynski <[email protected]>
|
@germa89 @greschd @Gryfenfer97 I don't see 0.5.2 on pypi. Was it released elsewhere and is there a reason we can't release it on pypi? |
|
I think it was just never tagged + pushed, see #13 (comment) |
|
New release is out: https://github.com/ansys/ansys-api-mapdl/releases/tag/v0.5.2 |
Relax the requirement on
protobuf, to allow using its4.x releases. See ansys/ansys-api-template#10.
Needs
ansys-tools-protoc-helperrelease0.4or newer,to compile with
protocversion3.19, see https://github.com/ansys-internal/ansys-tools-protoc-helper#upgrade-plans