Skip to content

Conversation

@deleon117
Copy link
Collaborator

No description provided.

@deleon117 deleon117 requested a review from Copilot September 8, 2025 19:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the ring mode coefficients terminology to ring mode index for better clarity. The change updates both the enum name and field name to reflect that these values represent indices rather than coefficient sets.

  • Renamed RingModeCoefficientSets enum to RingModeIndex with corresponding value name updates
  • Updated the field in MachineSettings from ring_mode_coefficient_set to ring_mode_index
  • Incremented version from 5.1.2-dev0 to 5.1.3-dev0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ansys/api/additive/v0/additive_domain.proto Renamed enum and field to use "index" terminology instead of "coefficient"
ansys/api/additive/VERSION Version bump to reflect the API change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@deleon117 deleon117 merged commit a358c3e into main Sep 8, 2025
4 checks passed
@deleon117 deleon117 deleted the deleon117/feat/rename-ring branch September 8, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants