Fix linking to libssh.so #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Member
|
I've fixed the CI on devel (it was broken for a while because of #150) and will now rebase this branch. |
The issue seems to be that the LDFLAGS env is not picked up or used properly in some instances. Explicitly listing the link in the pxd files causes the files to be built with `-lssh` properly.
webknjaz
force-pushed
the
fix-undefined
branch
from
f17c2b3 to
e6d33c4
Compare
Member
|
@Qalthos Weird... Does https://github.com/ansible/pylibssh/blob/bc911cc/pyproject.toml#L26 not help with this? |
webknjaz
approved these changes
Dec 5, 2020
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
Honestly, I was thinking that it's related to something like pygit2 troubleshooting describes at https://www.pygit2.org/install.html#the-run-path. But Let's merge it and see if that will fix our problem long-term.
I'll add a linting patch before merging because it now reports false-positives in flake8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #103 and resolves #63.
The issue seems to be that the LDFLAGS env is not picked up or used
properly in some instances. Explicitly listing the link in the pxd files
causes the files to be built with
-lsshproperly.ISSUE TYPE