Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Conversation

@timothystone
Copy link
Contributor

As presented, simply following the example will not run. This presents the Page Object example as a runnable set of spec + Page Object. See #4570

Open possibilities for future work include: carry the initial introduction over into a Page Object. Introduce world, etc.

so that it will run as presented. Open possibilities for future work, carry the initial introduction over into a Page Object. Introduce `world`, etc.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@timothystone
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 7, 2017
Corrected sentence structure.
@timothystone
Copy link
Contributor Author

How do you restart a build? looks like a timeout. Are there "tests" needed for this content?

@timothystone
Copy link
Contributor Author

The travis error looks false, a process timeout. Can someone evaluate?

@qiyigg
Copy link
Contributor

qiyigg commented Nov 14, 2017

tests have been rerun and passed.

@qiyigg qiyigg merged commit 8d71a1b into angular:master Nov 14, 2017
@timothystone timothystone deleted the patch-1 branch January 24, 2018 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants