This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(sauce): bring back sauceProxy as a configuration option #4419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kenisteward and @heathkit could you review my comments and PR? |
NickTomlin
approved these changes
Aug 2, 2017
Contributor
NickTomlin
left a comment
NickTomlin
left a comment
There was a problem hiding this comment.
💃 I think this makes sense to me
|
The change looks good. In the comments I'd specify the proxy is used
specifically with the saucelabs library to make rest API calls for saucelabs
…On Tue, Aug 1, 2017, 5:03 PM Craig ***@***.***> wrote:
@kenisteward <https://github.com/kenisteward> could you review my
comments and PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4419 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMPLtQK_rIzPTSOiaTgaty7RVttgVhohks5sT6CUgaJpZM4OqWkh>
.
|
|
Tha KS for this revision
…On Wed, Aug 2, 2017, 5:55 PM Kenneth Steward ***@***.***> wrote:
The change looks good. In the comments I'd specify the proxy is used
specifically with the saucelabs library to make rest API calls for saucelabs
On Tue, Aug 1, 2017, 5:03 PM Craig ***@***.***> wrote:
> @kenisteward <https://github.com/kenisteward> could you review my
> comments and PR?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4419 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AMPLtQK_rIzPTSOiaTgaty7RVttgVhohks5sT6CUgaJpZM4OqWkh>
> .
>
|
cnishina
force-pushed
the
webdriver-proxy
branch
from
b43498d to
8236adb
Compare
Reverts the change to PR angular#3868. Protractor should connect to Sauce Labs via the sauceProxy. This is different than the webDriverProxy. The webDriverProxy is tied to the browser session where we define where the traffic will go through. closes angular#4405
cnishina
force-pushed
the
webdriver-proxy
branch
from
8236adb to
557685f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the change to PR #3868. Protractor should connect to Sauce Labs
via the sauceProxy. This is different than the webDriverProxy. The
webDriverProxy is tied to the browser session where we define where the
traffic will go through.
closes #4405