Improve rootElement default

[juliemr]

At the moment, rootElement defaults to body, which is not particularly smart. It can be set manually, but we can improve the experience here.

[sjelin]

If we're willing to make undefined a special case we could have the default be:

• Look for [ng-app], [ng:app], and if exactly one result is found use that
• Otherwise, use body (or maybe throw an error?)

[galxy25]

Whoa, I was just about to open an issue on this topic, good to see this is something the protractor team is looking into.

I sporadically get errors like:

Error: Error while waiting for Protractor to sync with the page: "root element (body) has no injector. this may mean it is not inside ng-app."
Stacktrace:
Error: Error while waiting for Protractor to sync with the page: "root element (body) has no injector. this may mean it is not inside ng-app."
at Error ()
==== async task ====
Protractor.waitForAngular()
at [object Object]. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:39:37)
==== async task ====
Asynchronous test function: it()
Error
at [object Object]. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:38:7)
at [object Object]. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:28:5)
at Object. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:6:3)
at Object. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:127:4)
at Object.loadFile (/home/ubuntu/skraphaug/angular/node_modules/coffee-script/lib/coffee-script/register.js:16:19)
at require (module.js:380:17)
at Function.promise (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:650:9)
at _fulfilled (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:797:54)
at self.promiseDispatch.done (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:826:30)
at Promise.promise.promiseDispatch (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:759:13)
at /home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:525:49
at flush (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:419:13)

While for us, our homepage declares ng-app on the html tag,

Which lead me to this thread on SO
http://stackoverflow.com/questions/20059943/running-into-error-while-waiting-for-protractor-to-sync-with-the-page-with-basic

Would you suggest just adding root-element of html in my conf.js file? Why is it that the majority of the time protractor doesn't throw this error, when the default root element is body but that is not where I have set my ng-app at.

[sjelin]

If body is not the root element of your ng-app, you should specify what element is in your conf.js, yes

[galxy25]

@sjelin thanks, I've specified rootElement: 'html' now in my cont.js file, just extremely curious as to why protractor 90% of the time never complained that it was looking for the rootElement on body, with my ng-app being defined on html

[sjelin]

Please ask questions like this on stack overflow. (Also I think that angular isn't loading properly)

[Droogans]

@sjelin I think I've got a fix that works. I'll post (and answer) a stackoverflow question and delete this.

EDIT: http://stackoverflow.com/questions/28908878/protractor-tests-find-no-injector-in-my-app-but-only-on-jenkins

[henrahmagix]

+1 for looking for [ng-app], [ng:app] and defaulting to body if 0 or >1 results found.

[henrahmagix]

I've set rootElement: 'html' but I still get the error in a test that involves a redirect/reload not triggered by the control flow. I posted detailed information on http://stackoverflow.com/questions/30783518/protractor-test-sometimes-fails-when-reloading-angular-app

[Javilete]

Hello, I have been reading about this issue that randomly, my protractor test is failing because of the same error mentioned above (Error while waiting for Protractor to sync with the page: "root element (body) has no injector. this may mean it is not inside ng-app.) Is there a solution there that guarantees consistency? My application does the bootstrapping manually, so the ng-app is set to body but sometimes I get this error. I have tried to set rootElement: 'html' but the tests fail sometimes. Can you please advise guys if you have found a solution for this? Thanks in advance.

[sjelin]

Please ask support questions on stack overflow. Also, you probably want rootElement: 'body'

[Javilete]

Ok, thanks!