Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(panel): add the ability to update the animation of an existing panel #9895

Merged
merged 1 commit into from
Nov 17, 2016
Merged

feat(panel): add the ability to update the animation of an existing panel #9895

merged 1 commit into from
Nov 17, 2016

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 23, 2016 •
edited
Loading

  • Adds the ability to update the animation of a panel, without having to re-create it.
  • Adds a unit test for verifying that the backdrop animation duration matches the one of the panel. This was missed in feat(panel): configurable animation duration #9570.

@crisbeto crisbeto added the needs: review This PR is waiting on review from the team label Oct 23, 2016
@crisbeto crisbeto changed the title feat(panel): add the ability to update the animation of an existing p… feat(panel): add the ability to update the animation of an existing panel Oct 23, 2016
@crisbeto
feat(panel): add the ability to update the animation of an existing p…
b315698 
…anel

* Adds the ability to update the animation of a panel, without having to re-create it.
* Adds a unit test for verifying that the backdrop animation duration matches the one of the panel. This was missed in angular#9570.
@crisbeto crisbeto force-pushed the panel-update-animation branch from 825108a to b315698 Compare October 23, 2016 14:12
@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Oct 24, 2016

@ErinCoughlan, @bradrich - ping for review.

@ThomasBurleson ThomasBurleson added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Oct 24, 2016
@bradrich
Copy link
Contributor

bradrich commented Oct 24, 2016

LGTM

@ThomasBurleson ThomasBurleson added needs: presubmit and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: review This PR is waiting on review from the team labels Oct 24, 2016
ErinCoughlan
ErinCoughlan approved these changes Oct 24, 2016
View reviewed changes
Copy link
Contributor

@ErinCoughlan ErinCoughlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomasBurleson ThomasBurleson added this to the 1.1.2 milestone Oct 24, 2016
@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels Nov 17, 2016
@kara kara merged commit a6f0de7 into angular:master Nov 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ErinCoughlan ErinCoughlan ErinCoughlan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ErinCoughlan ErinCoughlan

@bradrich bradrich

Labels

pr: merge ready This PR is ready for a caretaker to review

Projects

None yet

Milestone

1.1.2

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @ThomasBurleson @bradrich @ErinCoughlan @kara