This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(datepicker): remove negative margin if triangle icon is disabled #9853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
needs: presubmit
and removed
needs: review
Member
|
@crisbeto needs rebase |
Usually the datepicker uses padding and a negative margin to prevent clicks on the triangle button from shifting the entire element, which is unnecessary in the case where the triangle icon is disabled. This change removes the negative margin and padding in that case. Fixes angular#9850.
crisbeto
force-pushed
the
9850/datepicker-negative-margin
branch
from
585a4c3 to
e4693ce
Compare
Member
Author
|
Rebased @jelbourn. |
Contributor
|
@jelbourn - note this is targeted for release 1.1.3... not for next week's build. |
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the datepicker uses padding and a negative margin to prevent
clicks on the triangle button from shifting the entire element, which
is unnecessary in the case where the triangle icon is disabled. This
change removes the negative margin and padding in that case.
Fixes #9850.