Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@tdadone
Copy link

@tdadone tdadone commented Oct 28, 2015

On chip blur event handler was doing the same thing as the method in the controller, so I thought it should call the method to avoid code duplication and possible errors in the future.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tdadone
Copy link
Author

tdadone commented Oct 28, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@devversion
Copy link
Member

Thanks for you PR,
Please hold on the current Contribution Rules (Click here to view).

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc8, post-1.0 Nov 24, 2015
@ThomasBurleson ThomasBurleson modified the milestones: post-1.0 , Backlog Jan 5, 2016
@EladBezalel
Copy link
Member

Change LGTM, please rebase

@EladBezalel EladBezalel added needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved needs: feedback The issue creator or community need to respond to questions in this issue labels Mar 19, 2016
@ThomasBurleson ThomasBurleson removed needs: feedback The issue creator or community need to respond to questions in this issue needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved labels Apr 19, 2016
@Splaktar Splaktar removed this from the - Backlog milestone Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants