Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Conversation

@CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru added build pr: needs review pr: merge safe The caretaker can merge this PR without doing a presubmit labels Feb 15, 2018
@CaerusKaru CaerusKaru added this to the v5.0.0-beta.13 milestone Feb 15, 2018
@CaerusKaru
Copy link
Member Author

@devversion can you take a look at this?

@devversion devversion added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge and removed pr: needs review labels Feb 15, 2018
- env: "MODE=browserstack_required"
- env: "MODE=travis_required"
- stage: Deploy
env: "DEPLOY_MODE=build-artifacts"
Copy link
Member

@devversion devversion Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the if statements are missing here. So the PR is not really about conditional build stages. On Material we want to push build artifacts not in another build stage, because it can happen that BrowserStack/Saucelabs time out too often.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I had the formatting wrong and thought the if statements came before the env. I added a check for the publish-artifacts stage, can you PTAL again?

@ThomasBurleson ThomasBurleson merged commit ba38451 into master Feb 17, 2018
@devversion devversion deleted the adam/m2-pull-9949 branch February 17, 2018 16:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

build cla: yes pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants