Skip to content

Conversation

@crisbeto
Copy link
Member

Fixes an incorrect example in the menu docs and the matMenuContent being used incorrectly in a unit test.

Fixes #9944.

Fixes an incorrect example in the menu docs and the `matMenuContent` being used incorrectly in a unit test.

Fixes angular#9944.
@crisbeto crisbeto requested a review from kara as a code owner February 14, 2018 18:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 14, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 14, 2018
@jelbourn jelbourn merged commit 959804b into angular:master Feb 20, 2018
tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
Fixes an incorrect example in the menu docs and the `matMenuContent` being used incorrectly in a unit test.

Fixes #9944.
andrewseguin pushed a commit that referenced this pull request Feb 20, 2018
Fixes an incorrect example in the menu docs and the `matMenuContent` being used incorrectly in a unit test.

Fixes #9944.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mat-menu] Passing in data to a menu - mistake in documentation/example

3 participants