docs(select): Change select's openedChange output comment #9934
Conversation
googlebot
added
the
cla: yes
src/lib/select/select.ts
Outdated
| }); | ||
|
|
||
| /** Event emitted when the select has been opened. */ | ||
| /** Event emitted when the select has been opened (true) or closed (false). */ |
There was a problem hiding this comment.
I think the true/false is implied from the boolean typing. Something like "Event emitter when the select panel has been toggled" is clearer.
There was a problem hiding this comment.
Ok, I'll change it, but... I tried to make it clear that true is attached to the opening action and false is attached to the closing action.
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, but can you change the title to docs:...? Otherwise it'll show up as a bugfix in the changelog.
julianobrasil
changed the title
crisbeto
added
pr: lgtm
action: merge
julianobrasil
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Currently, the docs says the
openedChangeemits when the panel has been opened. It also emits when it has been closed though.Related to #9928, specifically #9928 (comment).