build: fix runtime errors not being logged out on karma initialization #9888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Feb 11, 2018
devversion
added
pr: lgtm
action: merge
Currently if something throws an error right after Karma has initialized, the log will look something like the following:
```
HeadlessChrome 0.0.0 (Windows 10 0.0.0) ERROR
{
"originalErr": {},
"__zone_symbol__currentTask": {
"type": "microTask",
"state": "notScheduled",
"source": "Promise.then",
"zone": "<root>",
"cancelFn": null,
"runCount": 0
}
}
```
These changes log out the stack trace explicitly so we have some more info to work with if it happens.
crisbeto
force-pushed
the
karma-proper-error-logging
branch
from
8de8aa6 to
67269de
Compare
CaerusKaru
added a commit
to angular/preboot
that referenced
this pull request
Feb 14, 2018
* Equivalent commit to angular/components#9888
CaerusKaru
added a commit
to angular/preboot
that referenced
this pull request
Feb 14, 2018
#74) * Equivalent commit to angular/components#9888
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
#9888) Currently if something throws an error right after Karma has initialized, the log will look something like the following: ``` HeadlessChrome 0.0.0 (Windows 10 0.0.0) ERROR { "originalErr": {}, "__zone_symbol__currentTask": { "type": "microTask", "state": "notScheduled", "source": "Promise.then", "zone": "<root>", "cancelFn": null, "runCount": 0 } } ``` These changes log out the stack trace explicitly so we have some more info to work with if it happens.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if something throws an error right after Karma has initialized, the log will look something like the following:
These changes log out the stack trace explicitly so we have some more info to work with if it happens.