chore: add bazel test rules for the cdk #9726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
pr: needs review
area: dev-infra
jelbourn
requested review from
andrewseguin,
crisbeto,
devversion and
josephperrott
as code owners
googlebot
added
the
cla: yes
mmalerba
approved these changes
Feb 1, 2018
| // Monkey-patch the resetTestingModule to destroy fixtures outside of a try/catch block. | ||
| // With https://github.com/angular/angular/commit/2c5a67134198a090a24f6671dcdb7b102fea6eba | ||
| // errors when destroying components are no longer causing Jasmine to fail. | ||
| testBed.resetTestingModule = function() { |
Contributor
There was a problem hiding this comment.
are fat-arrows not allowed in this file?
Member
Author
There was a problem hiding this comment.
It was originally a JS file that I copy-pasted. Fixed.
(the one function remaining is necessary since it deals with this)
jelbourn
force-pushed
the
bazel-karma
branch
2 times, most recently
from
b532e8b to
1fc14d5
Compare
Member
Author
|
I fixed the tests for table/portal. Having |
jelbourn
force-pushed
the
bazel-karma
branch
from
1fc14d5 to
90ec4ce
Compare
Member
Author
|
@mmalerba @alexeagle PTAL |
mmalerba
approved these changes
Feb 12, 2018
jelbourn
added
pr: lgtm
action: merge
This adds bazel test rules for everything under cdk/ and sets CircleCI Overlay tests don't work because there's not yet a way to pass through flags to the browser. These issues will be addressed in a follow-up PR.
jelbourn
force-pushed
the
bazel-karma
branch
from
90ec4ce to
94365a0
Compare
andrewseguin
added
the
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bazel test rules for everything under cdk/ and sets CircleCI to run them. Overlay tests don't work because there's not yet a way to pass through flags to the browser. These issues will be addressed in a follow-up PR.