refactor(tooltip): reuse OverlayRef and portal #9637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reworks the tooltip to reuse the `OverlayRef` after the first time it is opened, rather than destroying it and creating a new one for every subsequent open. This reduces the overhead from having the create the new overlays all the time. * Changes the signature of the `ConnectedPositionStrategy.withScrollableContainers` method to return the position strategy. This is primarily for consistency with the other methods.
crisbeto
added
pr: needs review
merge: caretaker note
googlebot
added
the
cla: yes
Member
Author
|
Caretaker note: there may be some tests that need an extra |
jelbourn
approved these changes
Jan 30, 2018
| this._scrollDispatcher.getAncestorScrollContainers(this._elementRef) | ||
| ); | ||
|
|
||
| strategy.onPositionChange.pipe(filter(() => !!this._tooltipInstance)).subscribe(change => { |
Member
There was a problem hiding this comment.
!! shouldn't be necessary here
Member
Author
There was a problem hiding this comment.
It is because filter's predicate function is a (value: T, index: number) => boolean.
jelbourn
added
pr: lgtm
action: merge
Member
|
Going to mark as major since it might affect unit tests |
tinayuangao
pushed a commit
that referenced
this pull request
Feb 9, 2018
* Reworks the tooltip to reuse the `OverlayRef` after the first time it is opened, rather than destroying it and creating a new one for every subsequent open. This reduces the overhead from having the create the new overlays all the time. * Changes the signature of the `ConnectedPositionStrategy.withScrollableContainers` method to return the position strategy. This is primarily for consistency with the other methods.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OverlayRefafter the first time it is opened, rather than destroying it and creating a new one for every subsequent open. This reduces the overhead from having the create new overlays all the time.ConnectedPositionStrategy.withScrollableContainersmethod to return the position strategy. This is primarily for consistency with the other methods.