chore: fix missing cdk table overview #9574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
requested review from
amcdnl,
andrewseguin and
jelbourn
as code owners
googlebot
added
the
cla: yes
andrewseguin
added
pr: lgtm
action: merge
Member
Author
|
Related PR on the |
jelbourn
reviewed
Jan 24, 2018
| }, | ||
| 'tooltip-delay': { | ||
| title: 'Tooltips with delay', | ||
| title: 'Tooltip with a show and hide delay', |
Member
There was a problem hiding this comment.
This file is auto-generated. You need to update the @title in each example.
Member
Author
There was a problem hiding this comment.
Sorry (should have mentioned it in the PR description): those are the up-to-date descriptions from the actual @title comments. The titles recently got updated, but the example-module just didn't get updated.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jan 25, 2018
* No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the `material-examples` build package is being built. References angular#9574.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jan 25, 2018
* No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the `material-examples` build package is being built. References angular#9574.
jelbourn
pushed a commit
that referenced
this pull request
Jan 25, 2018
No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the `material-examples` build package is being built. References #9574.
Member
|
@devversion could you rebase? |
Fixes that the cdk-table overview file is not showing up in the docs. Fixes angular#9554.
devversion
force-pushed
the
chore/fix-missing-cdk-table-overview
branch
from
18c321b to
f214f83
Compare
Member
Author
|
@jelbourn Done. |
jelbourn
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the cdk-table overview file is not showing up in the docs.
Fixes #9554.