refactor(progress-bar): use color mixin #9473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
requested review from
crisbeto,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
devversion
reviewed
Jan 19, 2018
src/lib/progress-bar/progress-bar.ts
Outdated
| Input, | ||
| ViewEncapsulation | ||
| } from '@angular/core'; | ||
| import {CanColor, mixinColor, ThemePalette} from '@angular/material/core'; |
Member
There was a problem hiding this comment.
ThemePalette seems to be unused
crisbeto
reviewed
Jan 19, 2018
| templateUrl: 'progress-bar.html', | ||
| styleUrls: ['progress-bar.css'], | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| encapsulation: ViewEncapsulation.None, |
Member
There was a problem hiding this comment.
You also have to add inputs: ['color'] to the metadata.
josephperrott
added
the
target: major
Contributor
Author
|
Done. |
crisbeto
added
pr: lgtm
action: merge
devversion
approved these changes
Jan 21, 2018
Member
|
@josephperrott why did you mark this as major? |
Member
|
@jelbourn The types are changed for the |
jelbourn
added
target: patch
Member
|
Changing to patch since it loosens the type rather than restricting it. Passes for all Google apps |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color attribute for the
progress-barnow uses the color mixin as every other component that is themable.