chore: reorganize cdk/a11y directory structure #9389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Jan 14, 2018
devversion
added
pr: lgtm
action: merge
Member
|
needs rebase |
josephperrott
added
pr: needs rebase
and removed
action: merge
crisbeto
force-pushed
the
cdk-a11y-reorganize
branch
from
d2216a6 to
d2bbd86
Compare
crisbeto
added
action: merge
Member
Author
|
Rebased. |
Member
|
@crisbeto Passes google presubmit, can merge as soon as it's rebased... again (sorry) |
crisbeto
force-pushed
the
cdk-a11y-reorganize
branch
from
d2bbd86 to
3f65af3
Compare
Member
Author
|
Rebased, |
Member
|
Looks like there's a build error now |
crisbeto
force-pushed
the
cdk-a11y-reorganize
branch
from
3f65af3 to
65b1744
Compare
Member
Author
|
Rebased and fixed a couple of wrong imports. |
* Since the `@angular/cdk/a11y` has grown a lot, it's becoming harder to navigate. These changes distribute the files into directories similarly to how we do it in `overlay`. * Removes individual imports from the focus trap tests in favor of importing the `A11yModule`.
crisbeto
force-pushed
the
cdk-a11y-reorganize
branch
from
65b1744 to
17d0c2e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angular/cdk/a11yhas grown a lot, it's becoming harder to navigate. These changes distribute the files into directories similarly to how we do it inoverlay.A11yModule.