Skip to content

build: add lint rule to prevent binding to class attribute directly #9289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2018
Merged

build: add lint rule to prevent binding to class attribute directly #9289

merged 1 commit into from
Jan 12, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 8, 2018

Adds a lint rule that prevents us from binding to [class] directly.

Fixes #8340.

@crisbeto
build: add lint rule to prevent binding to class attribute directly
a0b771f 
Adds a lint rule that prevents us from binding to `[class]` directly.

Fixes angular#8340.
@crisbeto crisbeto requested a review from jelbourn as a code owner January 8, 2018 20:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 8, 2018
jelbourn
jelbourn approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 9, 2018
@andrewseguin andrewseguin merged commit 74d906a into angular:master Jan 12, 2018
andrewseguin pushed a commit that referenced this pull request Jan 17, 2018
@crisbeto @andrewseguin
build: add lint rule to prevent binding to class attribute directly (#…
73f89bd 
…9289)

Adds a lint rule that prevents us from binding to `[class]` directly.

Fixes #8340.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create lint test to enforce not binding to the class attribute

5 participants

@crisbeto @jelbourn @googlebot @josephperrott @andrewseguin