build: fix builds not failing with compilation errors in unit tests #9248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Fixes the CI continuing to run even though it failed to compile, due to a couple of promises that weren't rejecting properly. This should avoids things like angular#9073 slipping through.
crisbeto
force-pushed
the
test-errors-not-failing
branch
from
3b0d085 to
a7a1724
Compare
crisbeto
added
pr: merge safe
and removed
in progress
crisbeto
changed the title
devversion
approved these changes
Jan 5, 2018
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. For some reason the lint CI task fails though.
devversion
added
pr: lgtm
action: merge
Member
Author
|
We've been getting some flakes from Travis these past couple of days. Restarting it now. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
…ngular#9248) Fixes the CI continuing to run even though it failed to compile, due to a couple of promises that weren't rejecting properly. This should avoids things like angular#9073 slipping through.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
…ngular#9248) Fixes the CI continuing to run even though it failed to compile, due to a couple of promises that weren't rejecting properly. This should avoids things like angular#9073 slipping through.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CI continuing to run even though it failed to compile, due to a couple of promises that weren't rejecting properly. This should prevent things like #9073 from slipping through.