feat(button): expose ripple instance #9170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
Member
|
@devversion passes Google presubmit, just needs rebase |
* Exposes the `MatRipple` instance of the button as a public property. This can be used to show ripple indicators for feature discoveries as seen on the Specs (https://material.io/guidelines/growth-communications/feature-discovery.html#feature-discovery-design-patterns). Quote from the specs "Ripples guide users through subsequent steps". Closes angular#4179
devversion
force-pushed
the
feat/button-expose-ripple-instance
branch
from
ec2c210 to
bee009a
Compare
Member
Author
|
@jelbourn Done. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatRippleinstance of the button as a public property.This can be used to show ripple indicators for feature discoveries as seen on the specs (https://material.io/guidelines/growth-communications/feature-discovery.html#feature-discovery-design-patterns).
Also a short quote from the specs
As soon as #7543 is being resolved, we can also have more detailed explanations about the
MatRippledirective. We could also have a guide that shows how to launch ripples on such components with an exposed ripple instance (e.g. button, slide-toggle, checkbox, radio)Closes #4179