Skip to content

Revert "fix(chips): event propagation not stopped by remove button (#8872) #9064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2017
Merged

Revert "fix(chips): event propagation not stopped by remove button (#8872) #9064

merged 1 commit into from
Dec 20, 2017

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Dec 20, 2017

This reverts commit c7e2d4e.

Found that this failed some tests that expected focus to be called in the chip, but the handleClick was not handled due to the remove's stopPropagation

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2017
josephperrott
josephperrott approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 20, 2017
@josephperrott josephperrott reopened this Dec 20, 2017
@josephperrott josephperrott merged commit 1bcd8ca into angular:master Dec 20, 2017
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 2, 2018
@andrewseguin @josephperrott
Revert "fix(chips): event propagation not stopped by remove button (a…
b6c5fb4 
…ngular#8772)" (angular#9064)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewseguin @josephperrott @googlebot