build: disallow namespace usage and bump stylelint #9022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crisbeto
commented
Dec 16, 2017
crisbeto
commented
- Enables a tslint rule that will prevent us from using namespaces. Based on the discussion in refactor: export component animations for reuse #8971.
- Bumps to the latest stylelint version.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto Please rebase |
josephperrott
added
pr: needs rebase
and removed
action: merge
crisbeto
force-pushed
the
disallow-namespac
branch
from
4305383 to
84cc0ce
Compare
|
Rebased @josephperrott. |
crisbeto
added
action: merge
|
@crisbeto I'm sorry, one more rebase |
* Enables a tslint rule that will prevent us from using namespaces. Based on the discussion in angular#8971. * Bumps to the latest stylelint version.
crisbeto
force-pushed
the
disallow-namespac
branch
from
84cc0ce to
066cc35
Compare
|
Rebased. |
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 2, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.