refactor(datepicker): switch to fakeAsync tests #8908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
approved these changes
Dec 9, 2017
mmalerba
added
pr: lgtm
action: merge
Contributor
|
Needs rebase |
andrewseguin
added
pr: needs rebase
and removed
action: merge
crisbeto
force-pushed
the
datepicker-fakeasync
branch
from
41381c2 to
1eef552
Compare
crisbeto
added
action: merge
* Switches over all of the datepicker tests to run in the `fakeAsync` zone, making them cleaner and more reliable. * Avoids recompiling all of the test components before each test.
crisbeto
force-pushed
the
datepicker-fakeasync
branch
from
1eef552 to
dfc3509
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 2, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fakeAsynczone, making them cleaner and more reliable.