chore: hide internal properties from selection-list api doc #8841
Conversation
googlebot
added
the
cla: yes
src/lib/list/selection-list.ts
Outdated
| private _changeDetector: ChangeDetectorRef, | ||
| @Optional() @Inject(forwardRef(() => MatSelectionList)) | ||
| public selectionList: MatSelectionList) { | ||
| private _selectionList: MatSelectionList) { |
There was a problem hiding this comment.
I doubt that many people are depending on this property in particular, but this is technically a breaking change.
There was a problem hiding this comment.
Good point. If really necessary we can deprecate it
There was a problem hiding this comment.
Might as well leave it, doesn't really hurt to leave it as public.
There was a problem hiding this comment.
Hm, but it doesn't really make sense from an API perspective. Also it shows up in the docs which is kind of unnecessary. I don't really mind keeping that property as it is. Just let me know.
devversion
force-pushed
the
chore/hide-internal-properties-selection-list
branch
from
5248d55 to
e97c69c
Compare
devversion
force-pushed
the
chore/hide-internal-properties-selection-list
branch
from
e97c69c to
f04b1f9
Compare
src/lib/list/selection-list.ts
Outdated
| @Input() | ||
| get disabled() { return (this.selectionList && this.selectionList.disabled) || this._disabled; } | ||
| get disabled() { | ||
| return this._disabled || this.selectionList && this.selectionList.disabled; |
There was a problem hiding this comment.
Add the parentheses around the second condition here? Otherwise it's a little ambiguous.
* Recently with the NgModel support for the selection list, the `onTouched` property has been added. This one needs to be prefixed with an underscore to be hidden in the docs. * Since the initial implementation of the selection-list the `selectionList` variable has been initialized publically in the constructor of the `MatListOption` and therefore shows up in the docs. This property has been made private now.
devversion
force-pushed
the
chore/hide-internal-properties-selection-list
branch
from
f04b1f9 to
9cd5a73
Compare
devversion
added
action: merge
…8841) * Recently with the NgModel support for the selection list, the `onTouched` property has been added. This one needs to be prefixed with an underscore to be hidden in the docs. * Since the initial implementation of the selection-list the `selectionList` variable has been initialized publically in the constructor of the `MatListOption` and therefore shows up in the docs. This property has been made private now.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
onTouchedproperty has been added. This one needs to be prefixed with an underscore to be hidden in the docs.selectionListvariable has been initialized publically in the constructor of theMatListOptionand therefore shows up in the docs. This property has been made private now.