Skip to content

refactor(overlay): more robust testing setup #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2017
Merged

refactor(overlay): more robust testing setup #8638

merged 1 commit into from
Nov 28, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 24, 2017

Reworks the testing setup for the ConnectedPositionStrategy and GlobalPositionStrategy to avoid constructing the services ourselves and to prevent failures like #8559.

@crisbeto
refactor(overlay): more robust testing setup
5a806d5 
Reworks the testing setup for the `ConnectedPositionStrategy` and `GlobalPositionStrategy` to avoid constructing the services ourselves and to prevent failures like angular#8559.
@crisbeto crisbeto requested a review from jelbourn as a code owner November 24, 2017 22:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 24, 2017
jelbourn
jelbourn approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 27, 2017
@tinayuangao tinayuangao merged commit 1a383ce into angular:master Nov 28, 2017
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Nov 29, 2017
@crisbeto @tinayuangao
refactor(overlay): more robust testing setup (angular#8638)
a52e8da 
Reworks the testing setup for the `ConnectedPositionStrategy` and `GlobalPositionStrategy` to avoid constructing the services ourselves and to prevent failures like angular#8559.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @tinayuangao