build: fix invalid umd globals for rxjs operators #8572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Previously in `RxJS`, operators were part of the `Rx.Observable` namespace, but now since those will be imported separately from the `rxjs/operators` path, the UMD module name mapping needs to be updated to `Rx.operators` (https://unpkg.com/[email protected]/bundles/Rx.js) Fixes angular#8530
devversion
force-pushed
the
build/fix-umd-operator-mappings
branch
from
a9868be to
657bf72
Compare
jelbourn
added
pr: lgtm
action: merge
tinayuangao
pushed a commit
to tinayuangao/material2
that referenced
this pull request
Nov 29, 2017
Previously in `RxJS`, operators were part of the `Rx.Observable` namespace, but now since those will be imported separately from the `rxjs/operators` path, the UMD module name mapping needs to be updated to `Rx.operators` (https://unpkg.com/[email protected]/bundles/Rx.js) Fixes angular#8530
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in
RxJS, operators were part of theRx.Observablenamespace, but now since those will be imported separately from therxjs/operatorspath, the UMD module name mapping needs to be updated toRx.operators(https://unpkg.com/[email protected]/bundles/Rx.js)Fixes #8530