Skip to content

Conversation

@trotyl
Copy link
Contributor

@trotyl trotyl commented Nov 13, 2017

Current Behavior:

UMD bundles are completely BROKEN for global fallback!!!
Even though I guess it's still low priority since few people are using it.

All material/cdk modules are using camelCase in import and kebab-case in export, making it unable to connect.

Export (example):

global.ng.material['form-field'] /* kebab-case here */ = global.ng.material['form-field'] || {}

Import (example):

global.ng.material.formField /* camelCase here */

Expect Behavior:

Always use camelCase variable/property in global name.

Others

  • Only modules with composite names were broken, single-word module not affected;
  • Not sure about the scope of this commit since it's too wide, any suggestion?

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 13, 2017
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 13, 2017
@jelbourn jelbourn merged commit 40be1f2 into angular:master Nov 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants