Skip to content

docs: add table-selection example #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2017
Merged

docs: add table-selection example #8377

merged 1 commit into from
Nov 20, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Nov 11, 2017

  • Adds the table-selection example to the ExamplesModule.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2017
amcdnl
amcdnl reviewed Nov 17, 2017
View reviewed changes
src/material-examples/example-module.ts
additionalFiles: null,
selectorName: null
},
'table-selection': {
Copy link
Contributor

@amcdnl amcdnl Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was generated and not typed manually? We should probably remove this file from Git even.

Copy link
Member Author

@devversion devversion Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was just the gulp task that generates that file.

amcdnl
amcdnl approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 17, 2017
@devversion
docs: add table-selection example
387649d 
* Adds the table-selection example to the `ExamplesModule`.
@devversion devversion force-pushed the docs/table-selection-example branch from 8195ed3 to 387649d Compare November 19, 2017 09:10
@jelbourn jelbourn merged commit 0bacebf into angular:master Nov 20, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

1 more reviewer

@amcdnl amcdnl amcdnl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devversion @amcdnl @jelbourn @googlebot @andrewseguin