chore: add guidance on getters/setters to coding standards #7977
Conversation
googlebot
added
the
cla: yes
amcdnl
left a comment
amcdnl
left a comment
There was a problem hiding this comment.
What about Input should always be on setter?
Setters should come before getters?
|
@amcdnl added |
CODING_STANDARDS.md
Outdated
|
|
||
|
|
||
| #### Getters and Setters | ||
| * Always use a `readonly` property instead of a getter (with no setter) when possible. |
There was a problem hiding this comment.
Can you give an example? My brain is struggling to parse the use case
CODING_STANDARDS.md
Outdated
| * Always use a `readonly` property instead of a getter (with no setter) when possible. | ||
| * Avoid long getters and setters. If the logic of an accessor would take more than three lines, | ||
| introduce a new method to contain the logic. | ||
| * A getter should also immediately precede its corresponding setter. |
CODING_STANDARDS.md
Outdated
| * Always use a `readonly` property instead of a getter (with no setter) when possible. | ||
| * Avoid long getters and setters. If the logic of an accessor would take more than three lines, | ||
| introduce a new method to contain the logic. | ||
| * A getter should also immediately precede its corresponding setter. |
There was a problem hiding this comment.
If @Input is on setter, it should come first right? This is saying that getters precede the setter (getters come first)
There was a problem hiding this comment.
Getters come first, @input always goes on the getter.
jelbourn
force-pushed
the
code-guide-setters
branch
from
d1f265d to
88effdb
Compare
Expand with more points
jelbourn
force-pushed
the
code-guide-setters
branch
from
88effdb to
826ffb2
Compare
|
@amcdnl @andrewseguin poke for review |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
No description provided.