Skip to content

build: run tests with firefox headless #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2017
Merged

build: run tests with firefox headless #7828

merged 1 commit into from
Oct 18, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 16, 2017

No description provided.

@devversion devversion requested a review from jelbourn as a code owner October 16, 2017 14:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 16, 2017
@devversion devversion force-pushed the build/run-tests-firefox-headless branch from aa563b2 to 85ca0db Compare October 16, 2017 14:52
@devversion devversion force-pushed the build/run-tests-firefox-headless branch from 85ca0db to f982f93 Compare October 16, 2017 15:08
@devversion devversion requested a review from crisbeto as a code owner October 16, 2017 15:08
jelbourn
jelbourn approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 18, 2017
@tinayuangao tinayuangao merged commit fe08c2b into angular:master Oct 18, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @tinayuangao