chore(): forbidden identifiers check for relative scope imports. #764
Conversation
googlebot
added
the
cla: yes
scripts/ci/forbidden-identifiers.js
Outdated
|
|
||
| // Retrieves all scope packages dynamically from the source. | ||
| // Developers shouldn't be able to import from other scope packages by using relative paths. | ||
| const conpmponentFolders = fs |
There was a problem hiding this comment.
Yeah, good catch - definitely a cool naming convention :)
* Checks the added imports for any relative scope imports and automatically suggests the correct Scope Import statement.
devversion
force-pushed
the
chore/forbidden-relative-imports
branch
from
e840185 to
010d436
Compare
|
@hansl can you review this one? |
scripts/ci/forbidden-identifiers.js
Outdated
| const scopePackages = ['src/core'].concat(componentFolders); | ||
|
|
||
| const blockedRegex = new RegExp(blocked_statements.join('|'), 'g'); | ||
| const importRegex = /from '(.*)'/g; |
There was a problem hiding this comment.
This doesn't check if the line is an import. What if from '...' is put inside a comment?
There's no cases where you'd have multiple imports on a single line. I suggest the following regex:
const importRegex = /^import.*from\s+'(\S*)';/;Note that anything else would fail linting, so really this wouldn't be a problem.
|
LGTM with this note. Please fix and I'll merge. Cheers! |
src/components/checkbox/checkbox.ts
Outdated
| } from '@angular/core'; | ||
| import {NG_VALUE_ACCESSOR, ControlValueAccessor} from '@angular/common'; | ||
| forwardRef | ||
| } from '../../core/core'; |
There was a problem hiding this comment.
This was just commited for testing purposes and I already force-pushed to remove it :)
devversion
force-pushed
the
chore/forbidden-relative-imports
branch
from
5938be9 to
c3127eb
Compare
devversion
force-pushed
the
chore/forbidden-relative-imports
branch
from
c3127eb to
e9b4da6
Compare
|
LGTM! Let's wait for the tests to pass and I'll merge. Thanks a lot! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Once a forbidden import will be found, we will output a super helpful error message (including suggestion / correction)
cc. @jelbourn