Skip to content

Conversation

@FadySamirSadek
Copy link
Contributor

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2017
@jelbourn jelbourn requested review from mmalerba and removed request for amcdnl and jelbourn September 15, 2017 15:42
overflow: visible;
}

.example-scrolling-content {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually needed because the same class is used to make the sidenav content scroll. Actually can you add height: 100% to this instead? That should fix the issue where the FAB button in the content section scrolls up instead of staying fixed:

.example-scrolling-content {
  overflow: auto;
  height: 100%;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you , I fixed it in the next commit

Fixed review comments
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 18, 2017
@jelbourn jelbourn merged commit 95ab1eb into angular:master Sep 18, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants