fix(tooltip): error on trigger escape presses while closed #7028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ppham27
reviewed
Sep 13, 2017
src/lib/tooltip/tooltip.ts
Outdated
| /** Handles the keydown events on the host element. */ | ||
| _handleKeydown(e: KeyboardEvent) { | ||
| if (this._tooltipInstance!.isVisible() && e.keyCode === ESCAPE) { | ||
| if (this._tooltipInstance && this._tooltipInstance.isVisible() && e.keyCode === ESCAPE) { |
Contributor
There was a problem hiding this comment.
Sorry for the unsolicited comments. I just ran into the issue in our application. You can replace this is idiom with this._isTooltipVisible().
Fixes an error being thrown when pressing escape on a tooltip trigger that isn't showing a tooltip. Fixes angular#7009.
crisbeto
force-pushed
the
7009/tooltip-escape-null-ptr
branch
from
b9024c2 to
5d7df89
Compare
andrewseguin
approved these changes
Sep 19, 2017
andrewseguin
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error being thrown when pressing escape on a tooltip trigger that isn't showing a tooltip.
Fixes #7009.