refactor(selection-list): use disable-ripple mixin #6692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switches the `disableRipple` getter/setter with the `disableRipple` mixin from core. * Prefixes the `isRippleEnabled` method with an underscore to hide it from the API docs.
googlebot
added
the
cla: yes
crisbeto
reviewed
Aug 29, 2017
src/lib/list/list.ts
Outdated
|
|
||
| /** Whether this list item should show a ripple effect when clicked. */ | ||
| isRippleEnabled() { | ||
| _isRippleEnabled() { |
Member
There was a problem hiding this comment.
Perhaps rename this to _rippleDisabled so it matches the mixin name?
Member
Author
There was a problem hiding this comment.
Yeah that might be easier for the template as well.
Member
Author
There was a problem hiding this comment.
Done, but named it _isRippleDisabled.
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disableRipplegetter/setter with thedisableRipplemixin from core (payload reduction)isRippleEnabledmethod with an underscore to hide it from the API docs.