Skip to content

compat(sort): add mat compatible sort event #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2017
Merged

compat(sort): add mat compatible sort event #6611

merged 3 commits into from
Sep 18, 2017

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Aug 23, 2017

BREAKING CHANGE: Renaming mdSort's sort change stream property from mdSortChange to sortChange.

@andrewseguin andrewseguin requested a review from jelbourn August 23, 2017 17:38
@andrewseguin andrewseguin requested a review from amcdnl as a code owner August 23, 2017 17:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2017
jelbourn
jelbourn approved these changes Aug 23, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add merge-ready when ready

src/lib/sort/sort.ts Outdated

/** Event emitted when the user changes either the active sort or sort direction. */
@Output() mdSortChange = new EventEmitter<Sort>();
@Output('mdSortChange') sortChange = new EventEmitter<Sort>();
Copy link
Member

@jelbourn jelbourn Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also mark this as readonly?

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review action: merge The PR is ready for merge by the caretaker labels Aug 23, 2017
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2017
@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 23, 2017
@andrewseguin
Copy link
Contributor Author

andrewseguin commented Aug 28, 2017

Was there a caretaker note for this PR?

@andrewseguin andrewseguin added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Sep 14, 2017
@jelbourn jelbourn merged commit 86ec493 into angular:master Sep 18, 2017
@andrewseguin andrewseguin deleted the compat-sort-event-mat branch November 28, 2017 20:37
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewseguin @jelbourn @kara @googlebot