chore(overlay): refactor clipping detection calculation to its own file #6504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
approved these changes
Aug 16, 2017
| * Gets whether an element is clipped by any of its scrolling containers. | ||
| * @param element Dimensions of the element (from getBoundingClientRect) | ||
| * @param scrollContainers Dimensions of element's scrolling containers (from getBoundingClientRect) | ||
| * @returns Whether the element is clipped |
Member
There was a problem hiding this comment.
Should this be @docs-private as well?
| OriginConnectionPosition, | ||
| OverlayConnectionPosition, | ||
| ConnectedOverlayPositionChange, ScrollableViewProperties | ||
| ConnectedOverlayPositionChange, ScrollingVisibility |
jelbourn
force-pushed
the
clipping-refactor
branch
from
059838e to
5860114
Compare
Member
Author
|
Done and done |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving these functions out mainly to reduce the amount of code that goes in the position strategy