Skip to content

Conversation

@devversion
Copy link
Member

  • Adds the MdSortModule to the universal app. This means that it will be part of the prerender check on the CI.

Note: It makes sense to check the mdSort module because it includes components and directives that may cause problems in the server platform.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 7, 2017
@mmalerba mmalerba added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Aug 7, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Aug 7, 2017

please rebase

* Adds the `MdSortModule` to the universal app. This means that it will be part of the prerender check on the CI.
@devversion devversion force-pushed the chore/sort-module-prerender branch from ad0e1ae to 5dcc379 Compare August 7, 2017 17:26
@devversion
Copy link
Member Author

@mmalerba Done.

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Aug 7, 2017
@mmalerba mmalerba merged commit e94f26c into angular:master Aug 7, 2017
@devversion devversion deleted the chore/sort-module-prerender branch November 11, 2017 10:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants