chore(ci): block import of entire rxjs library

[jelbourn]

R: @hansl @kara

Thanks to @devversion for making me realize we need a check for this.

[hansl]

Can you elaborate? Is it because you want tree shaking?

[jelbourn]

@hansl Effectively; all of the imports for rxjs should be for the specific parts you want. If you do rxjs/Rx, it brings in the entire library. See icon.ts, for example, which does:

import {Observable} from 'rxjs/Observable';
import 'rxjs/add/observable/forkJoin';
import 'rxjs/add/observable/of';
import 'rxjs/add/operator/map';
import 'rxjs/add/operator/filter';
import 'rxjs/add/operator/do';
import 'rxjs/add/operator/share';
import 'rxjs/add/operator/finally';
import 'rxjs/add/operator/catch';

See #431

[hansl]

LGTM

[hansl]

Thank you for context.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}