Skip to content

Conversation

@rafaelss95
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 22, 2017
@rafaelss95
Copy link
Contributor Author

Note: This PR is here to ask if you're interested in adding this rule. If so, I can go ahead and fix all the incoming lint issues.

CC @jelbourn.

@jelbourn
Copy link
Member

While I agree we should prefer const, I'm concerned about the huge number of line changes this would cause. It would end up causing a lot of merge conflicts without providing any major value

@rafaelss95
Copy link
Contributor Author

@jelbourn Indeed. Maybe try to fix component by component (step by step) or just close this PR?

@jelbourn
Copy link
Member

I'd be okay with just closing since I don't think the preference for const over let makes a big enough difference to bother

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants