fix(input): don't highlight container when readonly input is focused #5776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Doesn't highlight the `md-input-container` if the underlying readonly input is focused. This is consistent with the native behavior both on PC and Mac. * Adds a unit test to ensure that the `mat-focused` class s being added. Fixes angular#5749.
googlebot
added
the
cla: yes
mmalerba
approved these changes
Jul 17, 2017
mmalerba
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 23, 2017
Prevents readonly inputs from being highlighted when they're focused. This is consistent with the native input behavior. Note: This was introduced initially through angular#5776, but it looks like it didn't make it through the transition to `mat-form-field`.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 29, 2017
Prevents readonly inputs from being highlighted when they're focused. This is consistent with the native input behavior. Note: This was introduced initially through angular#5776, but it looks like it didn't make it through the transition to `mat-form-field`.
|
it does not work on appearance="outline". |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-input-containerif the underlying readonly input is focused. This is consistent with the native behavior both on PC and Mac.mat-focusedclass is being added.Fixes #5749.