style(chips): clean up alignment and theming #5760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willshowell
commented
Jul 14, 2017
willshowell
commented
- Move size/positioning of remove icon out of demo and into chip styles
- Increase between chip margin to 8px to match spec
- Vertically align text and remove icon
- Make cursor default to match spec
- Add focus hover to match spec (in lieu of default outline)
- Clean up superfluous theming
- Remove non-themed selected styles since primary is the default color option
- Fix bug where a single input chip had no following margin
- Move size/positioning of remove icon out of demo - Increase between chip margin to 8px to match spec - Vertically align text and remove icon - Make cursor default to match spec - Add focus hover to match spec (in lieu of default outline) - Clean up superfluous theming - Remove non-themed selected styles since primary is the default color option
googlebot
added
the
cla: yes
Member
|
@tinayuangao should also take a quick look |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.