Skip to content

fix(datepicker): remove aria-expanded on datepicker input ... #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2017
Merged

fix(datepicker): remove aria-expanded on datepicker input ... #5746

merged 2 commits into from
Jul 20, 2017

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 13, 2017

since the attribute is not supported for text inputs. also only set aria-owns
attribute when the datepicker is open and therefore actually in the DOM.

fixes #5730
fixes #5729

@mmalerba mmalerba requested a review from jelbourn July 13, 2017 22:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 13, 2017
jelbourn
jelbourn reviewed Jul 14, 2017
View reviewed changes
src/lib/datepicker/datepicker-input.ts Outdated
'[attr.aria-expanded]': '_datepicker?.opened || "false"',
'[attr.aria-haspopup]': 'true',
'[attr.aria-owns]': '_datepicker?.id',
'[attr.aria-owns]': '_datepicker?.opened && _datepicker.id',
Copy link
Member

@jelbourn jelbourn Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test for this?

mmalerba added 2 commits July 14, 2017 11:23
@mmalerba
fix(datepicker): remove aira-expanded on datepicker input since the
043818d 
attribute is not supported for text inputs. also only set aria-owns
attribute when the datepicker is open and therefore actually in the DOM.
@mmalerba
add tests
5bbf235
@mmalerba
Copy link
Contributor Author

mmalerba commented Jul 14, 2017

done, and caught a bug \o/

jelbourn
jelbourn approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 14, 2017
@kara kara changed the title fix(datepicker): remove aira-expanded on datepicker input ... fix(datepicker): remove aria-expanded on datepicker input ... Jul 20, 2017
@kara kara merged commit 4ea4baa into angular:master Jul 20, 2017
@mmalerba mmalerba deleted the dp-aria branch April 3, 2018 15:18
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Datepicker input should not apply aria-expanded Datepicker puts aria-owns on input pointing to element not in the DOM

4 participants

@mmalerba @jelbourn @kara @googlebot